Allow choosing EOL and appending final newline #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #951 Adds the following options to js2svg and CLI: - eol — can be set to `lf` or `crlf`. If unspecified, js2svg uses the platform EOL. - finalNewline — defaults to false. If true, js2svg ensures any SVG output has a final newline. Tests added to cover both options.
|
Hi, could you clarify what's the point of finalNewline option? |
TrySound
reviewed
Sep 11, 2021
TrySound
reviewed
Sep 11, 2021
In a number of workspaces, files are required to have a final newline. For example, |
TrySound
reviewed
Sep 11, 2021
TrySound
reviewed
Sep 11, 2021
Aligns test format with refactor made in main branch
TrySound
reviewed
Sep 11, 2021
TrySound
reviewed
Sep 11, 2021
TrySound
reviewed
Sep 11, 2021
TrySound
reviewed
Sep 11, 2021
EOL is no longer converted to lower case, so only `crlf` and `lf` are now supported as options, not `CRLF` or `LF` or any other case.
TrySound
reviewed
Sep 11, 2021
Achieves parity with non-CLI behaviour of not allowing different cases
TrySound
reviewed
Sep 11, 2021
|
Thank you for working on this @adalinesimonian! |
Наконец-то! It's been a pleasure. 🎉 |
TrySound
added a commit
that referenced
this pull request
Sep 11, 2021
`os` package in js2svg module bothered me for a long time. We had to hack rollup to mock it for browser. Thanks to #1546 we now can pass eol from svgo-node entry point and simplify build.
TrySound
added a commit
that referenced
this pull request
Sep 11, 2021
`os` package in js2svg module bothered me for a long time. We had to hack rollup to mock it for browser. Thanks to #1546 we now can pass eol from svgo-node entry point and simplify build.
TrySound
added a commit
that referenced
this pull request
Sep 12, 2021
`os` package in js2svg module bothered me for a long time. We had to hack rollup to mock it for browser. Thanks to #1546 we now can pass eol from svgo-node entry point and simplify build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #951
Adds the following options to js2svg and CLI:
lforcrlf. If unspecified, js2svg uses the platform EOL.Tests added to cover both options.